build: cdi manual #23069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

crazy-max wants to merge 1 commit into docker:main from crazy-max:build-cdi

+538 −2

Member

crazy-max commented Jul 11, 2025 •

edited

Loading

Description

Adds CDI page to build section.

Related issues or tickets

Reviews

Technical review
Editorial review
Product review

github-actions bot added the area/build label

netlify bot commented Jul 11, 2025 •

edited

Loading

✅ Deploy Preview for docsdocker ready!

Name	Link
🔨 Latest commit	`19103b6`
🔍 Latest deploy log	https://app.netlify.com/projects/docsdocker/deploys/68761140575aaa0008a44ffb
😎 Deploy Preview	https://deploy-preview-23069--docsdocker.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

crazy-max force-pushed the build-cdi branch 5 times, most recently from 5465608 to 4ef0c39 Compare

July 11, 2025 11:43

crazy-max requested review from tonistiigi, thompson-shaun, aevesdocker, colinhemmings and sarahsanders-docker

July 11, 2025 11:51

crazy-max marked this pull request as ready for review

July 11, 2025 11:51

crazy-max requested a review from ArthurFlag as a code owner

July 11, 2025 11:51

Contributor

ArthurFlag commented Jul 11, 2025

Could you edit this line to

SECRETS_SCAN_OMIT_PATHS = "public/contribute/file-conventions/index.html,public/content/manuals/build/building/cdi.html"

?

github-actions bot added the area/release label

ArthurFlag requested changes

View reviewed changes

netlify.toml Outdated Show resolved Hide resolved

crazy-max force-pushed the build-cdi branch from 548a489 to d78b285 Compare

July 11, 2025 12:52

Member Author

crazy-max commented Jul 11, 2025 •

edited

Loading

Thanks looks good now but do you know why it is happening? Looking at the logs: https://app.netlify.com/projects/docsdocker/deploys/6870f8f33387050008ca7b11

1:45:06 PM: ❯ Scanning complete. 8540 file(s) scanned. Secrets scanning found 0 instance(s) of secrets and 1 instance(s) of likely secrets in build output or repo code.
1:45:06 PM: 
1:45:06 PM: "LS0t***" detected as a likely secret:
1:45:06 PM:   found value at line 719 in public/build/building/cdi/index.html
1:45:06 PM: 
1:45:06 PM: To prevent exposing secrets, the build will fail until these likely secret values are not found in build output or repo files.
1:45:06 PM: 
1:45:06 PM: If these are expected, use SECRETS_SCAN_SMART_DETECTION_OMIT_VALUES, or SECRETS_SCAN_SMART_DETECTION_ENABLED to prevent detecting.
1:45:06 PM: 
1:45:06 PM: For more information on secrets scanning, see the Netlify Docs: https://ntl.fyi/configure-secrets-scanning
1:45:06 PM: 
1:45:06 PM: Secrets scanning detected secrets in files during build.      
1:45:06 PM: ────────────────────────────────────────────────────────────────

It says cdi page contains LS0t*** as secret but I don't have any occurrence like this.

thompson-shaun approved these changes

View reviewed changes

crazy-max force-pushed the build-cdi branch from d78b285 to b56f0e5 Compare

July 11, 2025 14:47

Contributor

ArthurFlag commented Jul 11, 2025

The LST0 issue is the one we had a few weeks ago: it comes from codeblocks that we convert into Base64 for the copy button, so one of your codeblocks contains that string once converted 🙃

Member Author

crazy-max commented Jul 11, 2025

The LST0 issue is the one we had a few weeks ago: it comes from codeblocks that we convert into Base64 for the copy button, so one of your codeblocks contains that string once converted 🙃

Ah I see but still wonder why just file-conventions and cdi pages are affected and not others using codeblocks?

crazy-max force-pushed the build-cdi branch 2 times, most recently from b0fd26d to 3153d21 Compare

July 11, 2025 16:09

Member

thaJeztah commented Jul 11, 2025

Ah I see but still wonder why just file-conventions and cdi pages are affected and not others using codeblocks?

I guess just "luck" if the script base64 encodes the content of the codeblock (before styling).

Member

thaJeztah commented Jul 11, 2025

Did a quick check; LS0t is --- (base64 encoded)

thaJeztah reviewed

View reviewed changes

content/manuals/build/building/cdi.md Outdated

+              used here, it looks like this:
+              ```yaml {collapse=true}
+              ---

Member

thaJeztah Jul 11, 2025

So; this probably is the cause 😆

Member Author

crazy-max Jul 11, 2025

Ah yes indeed looks related to

docs/layouts/_default/_markup/render-codeblock.html

Line 25 in 4ab3804

x-data="{ code: '{{ encoding.Base64Encode .Inner }}', copying: false }"

that was introduced in #18545

ArthurFlag requested changes

View reviewed changes

Contributor

ArthurFlag left a comment

Great stuff. The troubleshooting in the middle of it will be super useful for AI scrapers 👍

content/manuals/build/building/cdi.md Outdated Show resolved Hide resolved

content/manuals/build/building/cdi.md Outdated Show resolved Hide resolved

crazy-max force-pushed the build-cdi branch from 3153d21 to bdc31c9 Compare

July 14, 2025 10:22

crazy-max force-pushed the build-cdi branch from bdc31c9 to 919a4ca Compare

July 14, 2025 10:22

crazy-max requested a review from ArthurFlag

July 14, 2025 10:24

ArthurFlag approved these changes

View reviewed changes

thaJeztah reviewed

View reviewed changes

Member

thaJeztah left a comment

Looks like I started writing some comments that I didn't submit yet 😂

content/manuals/build/building/cdi.md Outdated Show resolved Hide resolved

content/manuals/build/building/cdi.md

+              cdiVersion: "0.6.0"
+              kind: "vendor1.com/device"
+              devices:
+              - name: foo

Member

thaJeztah Jul 14, 2025

Perhaps we could use some name like my-device instead of foo (probably also for the filename and env-var)

content/manuals/build/building/cdi.md

Comment on lines +75 to +95

+              GC Policy rule#0:
+               All:            false
+               Filters:        type==source.local,type==exec.cachemount,type==source.git.checkout
+               Keep Duration:  48h0m0s
+               Max Used Space: 658.9MiB
+              GC Policy rule#1:
+               All:            false
+               Keep Duration:  1440h0m0s
+               Reserved Space: 4.657GiB
+               Max Used Space: 953.7MiB
+               Min Free Space: 2.794GiB
+              GC Policy rule#2:
+               All:            false
+               Reserved Space: 4.657GiB
+               Max Used Space: 953.7MiB
+               Min Free Space: 2.794GiB
+              GC Policy rule#3:
+               All:            true
+               Reserved Space: 4.657GiB
+               Max Used Space: 953.7MiB
+               Min Free Space: 2.794GiB

Member

thaJeztah Jul 14, 2025

Perhaps we should omit these in the example output, as they're not really relevant for this manual, e.g.;

Suggested change

      
            GC Policy rule#0:
          
             All:            false
          
             Filters:        type==source.local,type==exec.cachemount,type==source.git.checkout
          
             Keep Duration:  48h0m0s
          
             Max Used Space: 658.9MiB
          
            GC Policy rule#1:
          
             All:            false
          
             Keep Duration:  1440h0m0s
          
             Reserved Space: 4.657GiB
          
             Max Used Space: 953.7MiB
          
             Min Free Space: 2.794GiB
          
            GC Policy rule#2:
          
             All:            false
          
             Reserved Space: 4.657GiB
          
             Max Used Space: 953.7MiB
          
             Min Free Space: 2.794GiB
          
            GC Policy rule#3:
          
             All:            true
          
             Reserved Space: 4.657GiB
          
             Max Used Space: 953.7MiB
          
             Min Free Space: 2.794GiB
          
            # ...

content/manuals/build/building/cdi.md Outdated Show resolved Hide resolved

content/manuals/build/building/cdi.md Outdated Show resolved Hide resolved

content/manuals/build/building/cdi.md Show resolved Hide resolved

content/manuals/build/building/cdi.md Outdated Show resolved Hide resolved

content/manuals/build/building/cdi.md

+              Now let's create a container builder named `gpubuilder` using Buildx:
+              ```console
+              $ docker buildx create --name gpubuilder --driver-opt "image=crazymax/buildkit:v0.23.2-ubuntu-nvidia" --bootstrap

Member

thaJeztah Jul 14, 2025

We probably want to have this somewhere more "official" I guess (not a blocker); how complicated is this image to build? Would it be an option to add the Dockerfile here (if it's just 2 .. 3 steps)?

Member Author

crazy-max Jul 15, 2025

Yes it will be in the future, this is tracked in moby/buildkit#5944.

Would it be an option to add the Dockerfile here (if it's just 2 .. 3 steps)?

It's the BuildKit Dockerfile so not an option 😅

Member

thaJeztah Jul 15, 2025

Gotcha! I was hoping it could be some COPY --from=buildkit-bin ... to compose the image, but based on a different base image.

Definitely not a blocker!

content/manuals/build/building/cdi.md Outdated Show resolved Hide resolved

content/manuals/build/building/cdi.md

+              title: Container Device Interface (CDI)
+              weight: 60
+              description: Using CDI to access GPUs and other devices in your builds
+              keywords: build, buildkit, buildx, guide, tutorial, cdi, device, gpu, nvidia, cuda, amd, rocm

Member

thaJeztah Jul 14, 2025

Looks like vale may need to be taught some of these acronyms (nvidia, coda ..) or would it be because they're lowercase here?

Member Author

crazy-max Jul 15, 2025 •

edited

Loading

I think keywords should be excluded from Vale analysis or at least don't check casing


          build: cdi manual

19103b6

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>

crazy-max force-pushed the build-cdi branch from 919a4ca to 19103b6 Compare

July 15, 2025 08:28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

thaJeztah thaJeztah left review comments

ArthurFlag ArthurFlag approved these changes

thompson-shaun thompson-shaun approved these changes

tonistiigi Awaiting requested review from tonistiigi

aevesdocker Awaiting requested review from aevesdocker

colinhemmings Awaiting requested review from colinhemmings

sarahsanders-docker Awaiting requested review from sarahsanders-docker

Labels

area/build area/release